-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(assistant): translate #16326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(assistant): translate #16326
Conversation
68b8c32 to
61bf192
Compare
4ecd0e2 to
2842d25
Compare
77ffc2b to
5eeae80
Compare
6e7c54b to
747223e
Compare
f5f80f6 to
1bd9a81
Compare
|
Good question. It seems very cumbersome to read long text in this half-screen-scrolling UI. I am assuming that most people will paste the text from somewhere else, in which case the specifics of the original text doesn't matter much. We can just keep the header bar sticky and scroll the rest like usual. Other than that, 2 small points:
|
0860e36 to
f158729
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16326.apk |
|
@kra-mo Here is the UI/UX. Screen.Recording.2026-01-22.at.15.22.08.mp4 |
4489c04 to
4b1aae2
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
One point of feedback though:
Once the translation started, it would be good to display a different message on the bottom, just something like "Translating…" instead of showing a toast.
The existing message could then be adjusted to say "Press the translate button to begin" instead of "Your translation will appear here…" to indicate that translation is not instant, unlike in many other apps.
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # gradle/libs.versions.toml # Conflicts: # app/src/main/java/com/nextcloud/client/assistant/AssistantScreen.kt
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
4b1aae2 to
9ce6c24
Compare

Implements second part of it: nextcloud/files-clients#89 (comment)