Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 20, 2026

  • Tests written, or not not needed

Implements second part of it: nextcloud/files-clients#89 (comment)

@alperozturk96 alperozturk96 requested a review from kra-mo January 20, 2026 15:04
@alperozturk96 alperozturk96 marked this pull request as draft January 20, 2026 15:04
@alperozturk96 alperozturk96 force-pushed the feat/action-process-text-support branch from 68b8c32 to 61bf192 Compare January 21, 2026 09:55
@alperozturk96 alperozturk96 marked this pull request as ready for review January 21, 2026 09:56
@alperozturk96 alperozturk96 marked this pull request as draft January 21, 2026 09:56
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 2 times, most recently from 4ecd0e2 to 2842d25 Compare January 21, 2026 10:01
@alperozturk96 alperozturk96 force-pushed the feat/action-process-text-support branch from 77ffc2b to 5eeae80 Compare January 21, 2026 10:14
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 2 times, most recently from 6e7c54b to 747223e Compare January 21, 2026 11:29
Base automatically changed from feat/action-process-text-support to master January 21, 2026 13:36
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from f5f80f6 to 1bd9a81 Compare January 21, 2026 13:42
@nimishavijay
Copy link
Member

nimishavijay commented Jan 21, 2026

Good question. It seems very cumbersome to read long text in this half-screen-scrolling UI. I am assuming that most people will paste the text from somewhere else, in which case the specifics of the original text doesn't matter much. We can just keep the header bar sticky and scroll the rest like usual.

Other than that, 2 small points:

  • "Source language" seems a bit technical, we can change that to "Translate from"
  • It is not obvious from the UI that there is a dropdown for the languages, so we should add a small chevron-down icon next to the language.
  • There's also a floating button and I am not sure what it does (is it a button to force translation or create a "new translation task"?). would it be possible to just automatically translate whenever the source text changes (maybe throttled to 500ms or something to avoid sending too many requests)?

@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 0860e36 to f158729 Compare January 22, 2026 09:20
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16326.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 marked this pull request as ready for review January 22, 2026 14:21
@alperozturk96
Copy link
Collaborator Author

@kra-mo Here is the UI/UX.

Screen.Recording.2026-01-22.at.15.22.08.mp4

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code256256
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total479479

Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

One point of feedback though:

Once the translation started, it would be good to display a different message on the bottom, just something like "Translating…" instead of showing a toast.

The existing message could then be adjusted to say "Press the translate button to begin" instead of "Your translation will appear here…" to indicate that translation is not instant, unlike in many other apps.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	gradle/libs.versions.toml

# Conflicts:
#	app/src/main/java/com/nextcloud/client/assistant/AssistantScreen.kt
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 4b1aae2 to 9ce6c24 Compare January 23, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants