Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use css variables instead of magic numbers #4401

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

GVodyanov
Copy link
Contributor

Relevant to nextcloud/mail#9944

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Mar 22, 2025
@GVodyanov GVodyanov self-assigned this Mar 22, 2025
@GVodyanov GVodyanov requested a review from hamza221 as a code owner March 22, 2025 10:51
Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.13%. Comparing base (546da0b) to head (401f656).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...nts/AppNavigation/Settings/SettingsAddressbook.vue 0.00% 1 Missing ⚠️
src/components/ContactsList.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4401   +/-   ##
=========================================
  Coverage     11.13%   11.13%           
  Complexity      265      265           
=========================================
  Files           122      122           
  Lines          5539     5539           
  Branches       1188     1188           
=========================================
  Hits            617      617           
  Misses         4801     4801           
  Partials        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GVodyanov GVodyanov force-pushed the chore/use-css-variables branch from 11a6967 to 401f656 Compare March 22, 2025 10:55
@GVodyanov GVodyanov merged commit e5350bb into main Mar 24, 2025
38 of 39 checks passed
@GVodyanov GVodyanov deleted the chore/use-css-variables branch March 24, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants