fix window resize on DPI changes #7735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
approved these changes
Jan 10, 2025
nilsding
force-pushed
the
bugfix/client-window-resize-on-scale-change
branch
from
ae32d27 to
953d424
Compare
This commit fixes #7678 and likely fixes #7447 too. On Windows, when the screen is changed to one with a different scaling setting the window is being incorrectly resized. This can be worked around by storing the window's size before moving it to a different screen, and then resizing the window again. Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/client-window-resize-on-scale-change
branch
from
953d424 to
f352e8e
Compare
|
AppImage file: nextcloud-PR-7735-f352e8e2155a1b6dc74077b1a6f1abc037f88f23-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #7678 (and likely fixes #7447 too, as it looks to be caused by the same underlying issue).
On Windows, when the screen is changed to one with a different scaling setting the window is being incorrectly resized. This can be worked around by storing the window's size before moving it to a different screen, and then resizing the window again.
tested the change on Win11, Linux (Plasma/Wayland), and macOS (with an iPad as second screen)