Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update runwizard introduction screen #7737

Merged
merged 1 commit into from
Jan 13, 2025
Merged

update runwizard introduction screen #7737

merged 1 commit into from
Jan 13, 2025

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Jan 9, 2025

No description provided.

@mgallien mgallien added this to the 3.16.0 milestone Jan 9, 2025
@mgallien
Copy link
Collaborator Author

mgallien commented Jan 9, 2025

duplicate of #5870

@mgallien mgallien mentioned this pull request Jan 9, 2025
Closed
@mgallien mgallien self-assigned this Jan 9, 2025
@mgallien mgallien force-pushed the feature/improveLoginFlowV2Dialog branch from fe305ea to bc50f49 Compare January 9, 2025 14:08
nilsding
nilsding requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, I much prefer buttons over link labels myself...

not sure if it makes a lot of sense to keep the names of the widgets as *Label considering they're buttons now though

src/gui/wizard/flow2authwidget.ui Outdated Show resolved Hide resolved
src/gui/wizard/flow2authwidget.ui Outdated Show resolved Hide resolved
src/gui/wizard/flow2authwidget.ui Outdated Show resolved Hide resolved
src/gui/wizard/flow2authwidget.ui Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the feature/improveLoginFlowV2Dialog branch from bc50f49 to 958d8fe Compare January 10, 2025 09:23
@mgallien
Copy link
Collaborator Author

looks good overall, I much prefer buttons over link labels myself...

not sure if it makes a lot of sense to keep the names of the widgets as *Label considering they're buttons now though

all done
thanks for the suggestion

@mgallien mgallien requested a review from nilsding January 10, 2025 09:23
@mgallien mgallien force-pushed the feature/improveLoginFlowV2Dialog branch from 958d8fe to 249dc54 Compare January 13, 2025 14:38
@mgallien mgallien enabled auto-merge January 13, 2025 14:38
@mgallien mgallien force-pushed the feature/improveLoginFlowV2Dialog branch from 249dc54 to ddc4d4f Compare January 13, 2025 14:40
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7737-ddc4d4fe62495c4d5ea1f7e28148d2ff140104ca-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mgallien mgallien merged commit e90d049 into master Jan 13, 2025
14 of 17 checks passed
@mgallien mgallien deleted the feature/improveLoginFlowV2Dialog branch January 13, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsding nilsding nilsding approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@claucambra claucambra Awaiting requested review from claucambra

Assignees

@mgallien mgallien

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @nilsding @AnkurBavisa