Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Install Instructions #8086

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Fix Install Instructions #8086

merged 2 commits into from
Mar 28, 2025

Conversation

alexknop
Copy link
Contributor

Problem:

Tried to use instructions in README to set up my own environment, but noticed the cmake option -DCMAKE_INSTALL_PREFIX is in here twice. It did not make sense what the folder was supposed to be replaced with, but in terms of running this from the build directory, the second use of the option "." made more sense.

Removed this and it succeeded.
Screenshot From 2025-03-26 15-42-28

Solution:
Remove (invalid) use of cmake option -DCMAKE_INSTALL_PREFIX
Fix small typo :)

@alexknop
Copy link
Contributor Author

It makes me wonder if you guys meant to use "-DCMAKE_PREFIX_PATH" to point to dependencies instead?

@camilasan
Copy link
Member

It makes me wonder if you guys meant to use "-DCMAKE_PREFIX_PATH" to point to dependencies instead?

yes, if you can fix it in this PR, that would be great :)

@nilsding
Copy link
Member

can confirm that it should've been CMAKE_PREFIX_PATH

the main docs reference it with both brew (macOS) and C:/CraftRoot (Windows)

@alexknop
Copy link
Contributor Author

It makes me wonder if you guys meant to use "-DCMAKE_PREFIX_PATH" to point to dependencies instead?

yes, if you can fix it in this PR, that would be great :)

done!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: knopalex <[email protected]>
Signed-off-by: knopalex <[email protected]>
@nilsding
Copy link
Member

thanks again for your contribution :D

Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-8086.zip

SHA256 checksum: 52dfff4ddab15e06e73c11114776de24df6ab69b9d931cd5b255cbbbdc637641

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding merged commit 6690ad9 into master Mar 28, 2025
16 checks passed
@nilsding nilsding deleted the instructions branch March 28, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants