Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 27, 2023

@nickvergessen
Copy link
Member Author

Failing run on stable28 before the merge of #11315
https://github.com/nextcloud/documentation/actions/runs/7005702281/job/19055942324

@nickvergessen
Copy link
Member Author

/backport to stable27

@provokateurin
Copy link
Member

This doesn't make much sense because it breaks silently and not due to PR changes. The only real solution is #11318

@nickvergessen
Copy link
Member Author

This doesn't make much sense because it breaks silently and not due to PR changes.

It would still notify us that the next release build will be broken.
But yeah #11318 is much better.

@provokateurin
Copy link
Member

It would still notify us that the next release build will be broken.

In that case running it as a cron would make more sense since none of the PRs will be the cause of the breakage and it would unnecessarly block merging fine PRs.

@nickvergessen
Copy link
Member Author

In that case running it as a cron would make more sense since none of the PRs will be the cause of the breakage and it would unnecessarly block merging fine PRs.

But no one would notice until a release, because no one is cron subscribed. Fixing is easy and straight forward once reported, so for now (until #11318 is there), I think this is a helpful step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants