Skip to content

update Talk basics docs: screenshot, markdown #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 3 commits into from
Mar 12, 2024
Merged

update Talk basics docs: screenshot, markdown #11395

Antreesy merged 3 commits into from
Mar 12, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 11, 2023 •
edited
Loading

##Markdown

image
image

Reminder

image
image

Updated screenshots

See files diff

@Antreesy Antreesy added this to the Nextcloud 29 milestone Dec 11, 2023
@Antreesy Antreesy requested a review from DorraJaouad December 11, 2023 23:22
@Antreesy Antreesy self-assigned this Dec 11, 2023
DorraJaouad
DorraJaouad reviewed Dec 12, 2023
View reviewed changes
@Antreesy Antreesy force-pushed the feat/noid/update-talk-basics-27 branch from c5670da to 714fd69 Compare December 12, 2023 14:27
@Antreesy Antreesy requested a review from DorraJaouad December 12, 2023 14:29
@Antreesy Antreesy marked this pull request as ready for review December 12, 2023 14:30
DorraJaouad
DorraJaouad reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots need to be updated :

  • File upload ( caption was added)
  • Other screenshots where the three dot menu is visible ( not critical though)

Also, I think we should add the guest name window to the doc

@Antreesy Antreesy force-pushed the feat/noid/update-talk-basics-27 branch from 714fd69 to 5e6a69e Compare March 12, 2024 11:22
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 12, 2024

Yay, three months!

Please note that it's intended to be fully backported to stable27, where we didn't have guest window and caption.
Let's do another round later for stable28, based on milestones: https://github.com/nextcloud/spreed/milestones?state=closed

@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 12, 2024

/backport to stable27

@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 12, 2024

/backport to stable28

@Antreesy Antreesy merged commit 42290b1 into master Mar 12, 2024
@Antreesy Antreesy deleted the feat/noid/update-talk-basics-27 branch March 12, 2024 11:55
This was referenced Mar 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees

@Antreesy Antreesy

Labels

3. to review feature: talk manual: user

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @DorraJaouad