Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(admin): Add documentation for contacts example content #12928

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Mar 26, 2025

☑️ Resolves

🖼️ Screenshots

Moved to contacts page 👇🏼
image

@hamza221 hamza221 force-pushed the enh/admin/example-contact branch 3 times, most recently from a809aac to a6dd50f Compare March 26, 2025 13:12
@hamza221 hamza221 self-assigned this Mar 26, 2025
@hamza221 hamza221 requested a review from rakekniven March 26, 2025 13:50
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 force-pushed the enh/admin/example-contact branch from 3d25bbd to 457d6b3 Compare March 26, 2025 13:58
@hamza221 hamza221 enabled auto-merge March 26, 2025 13:58
@hamza221 hamza221 merged commit ce427cd into master Mar 26, 2025
12 checks passed
@hamza221 hamza221 deleted the enh/admin/example-contact branch March 26, 2025 14:09
@rakekniven
Copy link
Member

Has nobody seen my change requests?

@hamza221
Copy link
Contributor Author

Has nobody seen my change requests?

Please check the changes, they were addressed

@rakekniven
Copy link
Member

Some has been tiny like a blank before the bracket or not using "he".

@hamza221
Copy link
Contributor Author

Some has been tiny like a blank before the bracket or not using "he".

Oh sorry, my bad I'll open a new PR
Please use the diff feature in gh, to make to change requests more clear

@hamza221
Copy link
Contributor Author

#12929

@rakekniven
Copy link
Member

Please use the diff feature in gh, to make to change requests more clear

Did not find it at a quick look at thought this could happen -> and it happened.

Thank you for your quick reply. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants