Skip to content

fix(trash bin): Improve clarity of files retention config #13017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(trash bin): Improve clarity of files retention config #13017

wants to merge 1 commit into from

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 7, 2025

No description provided.

@artonge artonge force-pushed the artonge/fix/trashbin_retention_d1 branch from 6da12de to dc88165 Compare April 7, 2025 08:49
@artonge artonge requested review from yemkareems and come-nc April 8, 2025 07:54
come-nc
come-nc reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the parenthesis or some form of it, to make it clear that deletion may never happen.

Also, quota can be infinite, in which case it will still delete files when storage is full I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc left review comments

@yemkareems yemkareems Awaiting requested review from yemkareems

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @come-nc