feat: Show lock status next to unlock button

[juliusknorr]

We can make use of the enabled check to hide the menu entry, which was commented out but seems to work nowadays.

That way we now can properly show a action menu entry as info about the lock state only if the file is locked.

	Unlocked	Locked
List view
Grid view

[juliusknorr]

@susnux I've been trying to work with this, however I noticed that when in grid view the action uses the title instead of the display name for the regular file action. Is this expected?

[susnux]

Is this expected?

Yes it was implemented that way by @skjnldsv
E.g. inline sharing action has displayname "shared" and title "shared by XYZ" then the grid view action shill show "shared by XYZ" as the text in the NcActions.

[juliusknorr]

Ok, rather unexpected but i think i found a feasible way now with adding an extra action to display the state. However it still uses the css to hide the inline action as I found it still valuable to have the state written out in both list and grid view.

[marcoambrosini]

I think it would be more appropriate to use ncactioncaption for this, otherwise this info text just looks to similar to other action buttons.

[susnux]

I think it would be more appropriate to use ncactioncaption for this, otherwise this info text just looks to similar to other action buttons.

Thats not possible currently. You can only register actions (buttons) not text.

[marcoambrosini]

Got it. Can we at least make the button disabled (no hover, no cursor: pointer, not tabbable)?

[susnux]

Got it. Can we at least make the button disabled (no hover, no cursor: pointer, not tabbable)?

Also this is not possible - if the action is disabled it is not rendered at all.

I think if we want to have those status information we should do it as text and not introduce disabled buttons - those are an a11y nightmare. For now this way is probably the only feasible but we can of course implement improvements on the files app like you suggested @marcoambrosini :)

[skjnldsv]

Code looks sane, and thanks for the tests ❤️