refactor(dav): readability improvements

lib/DAV/GroupFoldersHome.php

@@ -18,6 +18,13 @@
 use Sabre\DAV\Exception\NotFound;
 use Sabre\DAV\ICollection;
 
+/**
+ * WebDAV collection representing a user's group folders home directory.
+ *
+ * Serves as a container for all group folders accessible to a specific user,
+ * providing read-only access to the list of group folders they can access.
+ * Each child node is a GroupFolderNode representing an individual group folder.
+ */
 class GroupFoldersHome implements ICollection {
 	public function __construct(
 		private array $principalInfo,
@@ -28,32 +35,27 @@ public function __construct(
 	}
 
 	public function delete(): never {
-		throw new Forbidden();
+		throw new Forbidden('Permission denied to delete this folder');
 	}
 
 	public function getName(): string {
 		[, $name] = \Sabre\Uri\split($this->principalInfo['uri']);
 		return $name;
 	}
 
-	public function setName($name): never {
+	public function setName(string $name): never {
 		throw new Forbidden('Permission denied to rename this folder');
 	}
 
-	public function createFile($name, $data = null): never {
-		throw new Forbidden('Not allowed to create files in this folder');
+	public function createFile(string $name, $data = null): never {
+		throw new Forbidden('Permission denied to create files in this folder');
 	}
 
-	public function createDirectory($name): never {
+	public function createDirectory(string $name): never {
 		throw new Forbidden('Permission denied to create folders in this folder');
 	}
 
 	private function getFolder(string $name): ?FolderDefinition {
-		$storageId = $this->rootFolder->getMountPoint()->getNumericStorageId();
-		if ($storageId === null) {
-			return null;
-		}
-
 		$folders = $this->folderManager->getFoldersForUser($this->user);
 		foreach ($folders as $folder) {
 			if (basename($folder->mountPoint) === $name) {
@@ -64,6 +66,11 @@ private function getFolder(string $name): ?FolderDefinition {
 		return null;
 	}
 
+	/**
+	 * Creates a GroupFolderNode for the given folder definition.
+	 *
+	 * @throws RuntimeException If the filesystem view cannot be obtained
+	 */
 	private function getDirectoryForFolder(FolderDefinition $folder): GroupFolderNode {
 		$userHome = '/' . $this->user->getUID() . '/files';
 		$node = $this->rootFolder->get($userHome . '/' . $folder->mountPoint);
@@ -76,9 +83,9 @@ private function getDirectoryForFolder(FolderDefinition $folder): GroupFolderNod
 		return new GroupFolderNode($view, $node, $folder->id);
 	}
 
-	public function getChild($name): GroupFolderNode {
+	public function getChild(string $name): GroupFolderNode {
 		$folder = $this->getFolder($name);
-		if ($folder) {
+		if ($folder !== null) {
 			return $this->getDirectoryForFolder($folder);
 		}
 
@@ -89,11 +96,6 @@ public function getChild($name): GroupFolderNode {
 	 * @return GroupFolderNode[]
 	 */
 	public function getChildren(): array {
-		$storageId = $this->rootFolder->getMountPoint()->getNumericStorageId();
-		if ($storageId === null) {
-			return [];
-		}
-
 		$folders = $this->folderManager->getFoldersForUser($this->user);
 
 		// Filter out non top-level folders
@@ -102,7 +104,7 @@ public function getChildren(): array {
 		return array_map($this->getDirectoryForFolder(...), $folders);
 	}
 
-	public function childExists($name): bool {
+	public function childExists(string $name): bool {
 		return $this->getFolder($name) !== null;
 	}