Fix: Remove extraneous JSON preamble from LLM responses#10966
Merged
Conversation
The most of the LLM's return in JSON markdown format, example:
```json
{
"reply1": "Received, thanks...",
"reply2": "Thanks for forwarding this..."
}
```
Adding additional instructions did't help.
This is solution to strip:
```json
```
from the answer.
Signed-off-by: sto-j <162719726+sto-j@users.noreply.github.com>
hamza221
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
ChristophWurst
approved these changes
Apr 4, 2025
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
fix/smart-replies-markdown
branch
from
34ff286 to
3dd8b5a
Compare
Member
|
/backport to stable5.0 |
Member
|
/backport to stable4.3 |
This comment was marked as resolved.
This comment was marked as resolved.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit test for #10957
Was not able to push to @sto-j 's branch