feat(routing): Support new Route attribute #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
commented
Jan 15, 2024
4 tasks
provokateurin
force-pushed
the
feat/routing/route-attribute
branch
2 times, most recently
from
53f7c4c to
a5553b6
Compare
Member
Author
|
Rebased to solve conflicts |
provokateurin
force-pushed
the
feat/routing/route-attribute
branch
from
a5553b6 to
5978fb3
Compare
Member
Author
|
Rebased once more to solve conflicts |
This was referenced Jan 24, 2024
provokateurin
force-pushed
the
feat/routing/route-attribute
branch
2 times, most recently
from
0750308 to
745c002
Compare
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/routing/route-attribute
branch
from
745c002 to
8733d1b
Compare
julien-nc
requested changes
Feb 13, 2024
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Tested with nextcloud/server#42801 . Works fine.
Let's change all the double quote strings to simple quotes in this PR.
A few minor comments but 👍
Member
Author
|
All the double quotes in this PR have serve purpose (string interpolation), so I will leave them as they are. |
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/routing/route-attribute
branch
from
8733d1b to
4771319
Compare
julien-nc
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server PR is following soon, but the added test can already verify the behaviour.