Skip to content

Add api for authoritative mount providers and implement it for files_external #56499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
icewind1991 wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add api for authoritative mount providers and implement it for files_external #56499

icewind1991 wants to merge 9 commits into from

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 17, 2025 •
edited
Loading

  • Add the api surface for mount providers to pro-actively update the list of cached mounts
  • Implement this for files_external as POC since it's one of the easiest ones

Note that this only adds the api for implementing authoritative mounts providers, it doesn't add any logic that rely on them.

TODO:

  • deal with new users, group changes, etc
  • don't get the root cache entry multiple times if there is no user-specific config

Best used with #56447 to easily see the mount listing

@icewind1991 icewind1991 added the 2. developing Work in progress label Nov 17, 2025
@icewind1991 icewind1991 force-pushed the authoritative-mount-provider-files_external branch 3 times, most recently from fbbbc26 to 3f1e180 Compare November 26, 2025 18:04
CarlSchwan
CarlSchwan reviewed Dec 10, 2025
View reviewed changes
@icewind1991 icewind1991 force-pushed the authoritative-mount-provider-files_external branch 8 times, most recently from 21677d9 to 3870269 Compare December 22, 2025 15:41
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 22, 2025
@icewind1991 icewind1991 added this to the Nextcloud 33 milestone Dec 22, 2025
@icewind1991 icewind1991 marked this pull request as ready for review December 22, 2025 15:41
@icewind1991 icewind1991 requested a review from a team as a code owner December 22, 2025 15:41
@icewind1991 icewind1991 requested review from come-nc, nfebe, provokateurin and salmart-dev and removed request for a team December 22, 2025 15:41
@icewind1991
feat: add interface to mark mount providers as authoritative
5e9ddc7 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
feat: add api for authoritative mount providers to update the user mo…
7fdfe90 
…unts

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
feat: add typed events for external storage config changes
5359078 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
feat: yield user by id in IUserManager::getSeenUsers
cfe1059 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
feat: make external storage mount provider authoritative
a49cc56 
Signed-off-by: Robin Appelman <[email protected]>

# Conflicts:
#	apps/files_external/lib/AppInfo/Application.php
@icewind1991
feat: listen to user/group events and update external storage mounts
1efb8ca 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
perf: cache root cache entries for external storage in MountCacheService
edea8cd 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the authoritative-mount-provider-files_external branch from 3870269 to e16d968 Compare December 31, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@artonge artonge Awaiting requested review from artonge

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991 @CarlSchwan