-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(NewUserDialog): update group selection to prevent admin group from being assigned as subadmin #57233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2feef0f to
f59a590
Compare
CarlSchwan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint CI is failing but looks good.
And this does need the same code also in the backend, as we shouldn't rely only on client side verification ;)
@CarlSchwan Thanks for your review. |
f59a590 to
a0d5b25
Compare
…m being assigned as subadmin Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>
a0d5b25 to
c81422e
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport c81422e to stable32 |
|
/backport c81422e to stable31 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This pull request updates the group selection logic in the
NewUserDialog.vuecomponent to prevent users from being assigned as sub-admins of theadmingroup. The main change is the introduction of a new computed property fromUserRow.vueto filter out theadmingroup from the selectable options for sub-admin assignment.Group selection improvements:
:optionsprop for the sub-admin group selection now uses the newavailableSubAdminGroupscomputed property, ensuring theadmingroup is excluded from the list of assignable sub-admin groups.availableSubAdminGroupscomputed property, which filters out theadmingroup fromavailableGroups.TODO
Checklist
3. to review, feature component)stable32)