feat(core): add support for NoTwoFactorRequired attribute in TwoFactorMiddleware #57301
+103
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
8 tasks
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Member
|
Similar to #55474 and here are some rector rules: nextcloud-libraries/rector#66 |
nickvergessen
approved these changes
Jan 12, 2026
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Anything blocking this?
| // Route handler explicitly marked to work without finished 2FA are not blocked | ||
| $reflectionMethod = new ReflectionMethod($controller, $methodName); | ||
| $hasNoTwoFactorAttribute = !empty($reflectionMethod->getAttributes(NoTwoFactorRequired::class)); | ||
| $hasNoTwoFactorAnnotation = $this->reflector->hasAnnotation('NoTwoFactorRequired'); |
Member
There was a problem hiding this comment.
Small performance improvement possible :P
Suggested change
| $hasNoTwoFactorAnnotation = $this->reflector->hasAnnotation('NoTwoFactorRequired'); | |
| $hasNoTwoFactorAnnotation = $hasNoTwoFactorAttribute || $this->reflector->hasAnnotation('NoTwoFactorRequired'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documented since v27, when attributes were added for other existing annotations, but this one appears to have been overlooked.
Also adds unit ests for the new attribute support + for the prior annotation support.
TODO
Checklist
3. to review, feature component)stable32)