Skip to content

fix(installer): make isDownloaded robust + unify parameter naming #57308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 2 commits into from
Jan 2, 2026
+17 −12
Merged

fix(installer): make isDownloaded robust + unify parameter naming #57308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a46f3bd
fix(installer): make isDownloaded robust + unify parameter naming
joshtrichards Jan 1, 2026
30f2932
chore: make lint happy about isDownloaded concat
joshtrichards Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions lib/private/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,15 +416,16 @@ private function isInstalledFromGit(string $appId): bool {
* Check if app is already downloaded
*
* The function will check if the app is already downloaded in the apps repository
* and has a valid appinfo/info.xml file.
*
* @return bool True if the app directory exists
*/
public function isDownloaded(string $name): bool {
public function isDownloaded(string $appId): bool {
foreach (\OC::$APPSROOTS as $dir) {
$dirToTest = $dir['path'];
$dirToTest .= '/';
$dirToTest .= $name;
$dirToTest .= '/';
$appPath = $dir['path'] . '/' . $appId;

if (is_dir($dirToTest)) {
// An app is considered "downloaded" if the directory exists with info.xml
if (is_dir($appPath) && file_exists($appPath . '/appinfo/info.xml')) {
return true;
}
}
Expand Down Expand Up @@ -587,18 +588,22 @@ private function installAppLastSteps(string $appPath, array $info, ?IOutput $out
}

/**
* install an app already placed in the app folder
* Install an app already placed in the app folder
*
* @param string $appId The app ID to install
* @param IOutput|null $output Optional output handler for logging installation progress
* @return string|false App ID on success, false on failure
*/
public function installShippedApp(string $app, ?IOutput $output = null): string|false {
public function installShippedApp(string $appId, ?IOutput $output = null): string|false {
if ($output instanceof IOutput) {
$output->debug('Installing ' . $app);
$output->debug('Installing ' . $appId);
}
$info = $this->appManager->getAppInfo($app);
if (is_null($info) || $info['id'] !== $app) {
$info = $this->appManager->getAppInfo($appId);
if (is_null($info) || $info['id'] !== $appId) {
return false;
}

$appPath = $this->appManager->getAppPath($app);
$appPath = $this->appManager->getAppPath($appId);

return $this->installAppLastSteps($appPath, $info, $output, 'yes');
}
Expand Down
Loading