-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
test(User): register Backend+DB users for proper cleanup #57438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
|
/backport to stable32 |
Signed-off-by: Josh <[email protected]>
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're just changing the way the usernames are generated, but they are not cleaned up afterwards like you said in the description.
I assume it still helps because the usernames have a unique prefix which should avoid collisions?
|
@provokateurin Backend's getUser isn't the one used; in the downstream implementations, tracking and cleanup is implemented in their own $this->getUser() implementations/etc. server/tests/lib/User/DatabaseTest.php Lines 32 to 35 in f15d811
server/tests/lib/User/DatabaseTest.php Lines 46 to 54 in f15d811
|
Signed-off-by: Josh <[email protected]>
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this wasn't clear from just looking at the diff 👍
Summary
Should help further with some flaky test failures. These users weren't being properly registered via getUser in the test scenarios for cleanup/teardown, leading to leaks between tests.
TODO
Checklist
3. to review, feature component)stable32)