-
Notifications
You must be signed in to change notification settings - Fork 32
Enhancement: Add column width setting #1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be10905 to
fca84dc
Compare
fca84dc to
bf5eb16
Compare
I don't think we need frontend tests for this. Unless you meant something else? |
758c157 to
0031e9f
Compare
|
@enjeck I've added Behat tests to make sure that we able to store value of the new property and fetch it back. PR rebased, conflicts solved, tests added. So, please, review |
8e9e19a to
54aa82c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left a few comments.
src/shared/components/ncTable/partials/columnTypePartials/forms/MainForm.vue
Outdated
Show resolved
Hide resolved
|
In As a result, This ensures that modifying |
src/shared/components/ncTable/partials/columnTypePartials/forms/MainForm.vue
Show resolved
Hide resolved
src/shared/components/ncTable/partials/columnTypePartials/forms/MainForm.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks for that! I’ve only reviewed the frontend code and suggested a few small changes. I’ve tested the UI in Firefox and Chromium, and it generally looks good, with just a few minor issues noted in the comments.
|
@silverkszlo I've updated PR according to your suggestions. Min width changed to |
b957801 to
b4013fb
Compare
2cbac98 to
3cc7dd1
Compare
9d53218 to
d0894a2
Compare
d0894a2 to
e5edb5a
Compare
src/shared/components/ncTable/partials/columnTypePartials/forms/MainForm.vue
Outdated
Show resolved
Hide resolved
src/shared/components/ncTable/partials/columnTypePartials/forms/MainForm.vue
Outdated
Show resolved
Hide resolved
| :style="{ | ||
| width: col.customSettings?.width ? `${col.customSettings.width}px` : 'auto', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, should we consider how these fixed widths would be like on mobile devices? Might run into a responsiveness issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
e5edb5a to
d70415a
Compare
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
d70415a to
2e4935b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you so much!



This PR adds possibility to configure column width on a table level. Closes #35
🔍 Preview
Configure width:
Column with fixed width:

TODO: