[stable0.9] feat: remove rows in view after edit when they no longer match filter #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
- backend: add new endpoint - controller & service: for server-side check - frontend: call check after insert and update, remove invalid rows - wrap rows in <transition-group> to animate removal - only animate when a row is removed due to filter mismatch - CSS: fade+collapse leave transition Closes #1691 Signed-off-by: Benjamin Frueh <[email protected]>
- changed endpoint to /view/{viewId}/row/{id}/present for consistency
- phpdoc for RowService isRowInViewPresent() return/throw behavior
- remove unnecessary rethrow in RowService isRowInViewPresent()
- change js checkRowInView() to avoid returning true on error
- moved duplicate js remove row logic into reusable function
Signed-off-by: Benjamin Frueh <[email protected]>
Signed-off-by: Benjamin Frueh <[email protected]>
enjeck
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1979