Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 28, 2023

This allows to run the app (e.g. for running behat tests) without the requirement to only install runtime dependencies. Previously vimeo/psalm pulled in symfony/console in a different version then what the server ships, so using the phar bundle instead isolates their dependencies.

Also removes phan/phan which was not used

@juliusknorr juliusknorr force-pushed the chore/fix-dependency-conflicts branch from a961ab1 to 44e4fbf Compare December 28, 2023 09:31
@juliusknorr juliusknorr force-pushed the chore/fix-dependency-conflicts branch 2 times, most recently from c28f83e to c668b13 Compare December 28, 2023 10:51
@juliusknorr
Copy link
Member Author

CI failure is unrelated (ref nextcloud/server#42504)

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@juliusknorr juliusknorr force-pushed the chore/fix-dependency-conflicts branch from c668b13 to c6ea131 Compare December 28, 2023 11:48
@juliusknorr juliusknorr added dependencies Pull requests that update a dependency file 4. to release Ready to be released and/or waiting for tests to finish labels Dec 28, 2023
@juliusknorr juliusknorr merged commit 34b595d into main Dec 28, 2023
@juliusknorr juliusknorr deleted the chore/fix-dependency-conflicts branch December 28, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants