WIP: Make build run without additional ram #5818
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Also drop the content arg to the serialize function as it is never provided Signed-off-by: Max <[email protected]>
We simply overwrite the `toMarkdown` function and then rely on that. Signed-off-by: Max <[email protected]>
We are now using this for serializing plaintext as well. Signed-off-by: Max <[email protected]>
We do need the session for initialization but we do not need the `documentSource` or `documentState` anymore Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
* Use const arrow functions when no doc comment is needed. * Use the tiptap api to inspect editor state rather than reaching deep into the editor state. Signed-off-by: Max <[email protected]>
Keep as `#getContent` internally. Use `serializeEditorContent(editor)` outside of the `SyncService`. Signed-off-by: Max <[email protected]>
The intermediate object with `serialize` and `serializer` is not needed anymore. Signed-off-by: Max <[email protected]>
No need pass the callbacks in createEditor. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Seems to be unused at the moment. Also did not find any use for it in the commit that introduced it. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/small-chunks
branch
3 times, most recently
from
1ac5834
to
fae0ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Currently we need to add more ram to the node runtime so it can build text.
This is due to rollup needing plenty of ram when building large chunks.
The critical chunk in question seems to be the Richtext one.
I'm working on breaking this up into smaller chunks
by reworking the editor creation process.
🚧 TODO
RichTextextension.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)