Skip to content

feat: Verify file integrity in chunks #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: Verify file integrity in chunks #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,14 +757,26 @@ public function verifyIntegrity(): void {
-----END CERTIFICATE-----
EOF;

$validSignature = openssl_verify(
file_get_contents($this->getDownloadedFilePath()),
base64_decode($response['signature']),
$certificate,
OPENSSL_ALGO_SHA512
) === 1;

if ($validSignature === false) {
$fh = fopen($this->getDownloadedFilePath(), 'r');
if ($fh === false) {
throw new \Exception('Failed to open downloaded file for integrity check');
}

$data = '';
while (!feof($fh)) {
$chunk = fread($fh, 8192);
if ($chunk === false) {
fclose($fh);
throw new \Exception('Error reading file during integrity check');
}
$data .= $chunk;
}
fclose($fh);

$signature = base64_decode($response['signature']);

$validSignature = openssl_verify($data, $signature, $certificate, OPENSSL_ALGO_SHA512);
if ($validSignature !== 1) {
throw new \Exception('Signature of update is not valid');
}

Expand Down
28 changes: 20 additions & 8 deletions lib/Updater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,14 +739,26 @@ public function verifyIntegrity(): void {
-----END CERTIFICATE-----
EOF;

$validSignature = openssl_verify(
file_get_contents($this->getDownloadedFilePath()),
base64_decode($response['signature']),
$certificate,
OPENSSL_ALGO_SHA512
) === 1;

if ($validSignature === false) {
$fh = fopen($this->getDownloadedFilePath(), 'r');
if ($fh === false) {
throw new \Exception('Failed to open downloaded file for integrity check');
}

$data = '';
while (!feof($fh)) {
$chunk = fread($fh, 8192);
if ($chunk === false) {
fclose($fh);
throw new \Exception('Error reading file during integrity check');
}
$data .= $chunk;
}
fclose($fh);

$signature = base64_decode($response['signature']);

$validSignature = openssl_verify($data, $signature, $certificate, OPENSSL_ALGO_SHA512);
Copy link
Member

@joshtrichards joshtrichards Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this chunk the initial read but still populate $data with the entire archive content leading to the same state?

In short, the chunking would only be helpful if openssl_verify itself did it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right. Using file_get_contents() or a loop that concatenates chunks into a string, ultimately results in the entire file being held in memory at once...

I'm closing this because i've thinked it wrongly, I'll try to provide a better PR later. Thanks 👍

if ($validSignature !== 1) {
throw new \Exception('Signature of update is not valid');
}

Expand Down
Loading