fix: add password confirmation to change admin settings #991
Conversation
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
| use OCP\AppFramework\Controller; | ||
| use OCP\AppFramework\Db\DoesNotExistException; | ||
| use OCP\AppFramework\Http; | ||
| use OCP\AppFramework\Http\Attribute\PasswordConfirmationRequired; |
There was a problem hiding this comment.
This line should be deleted 😉.
After having committed this change, you can squash the 3 last commits together with git rebase -i HEAD~3 and force push.
Co-authored-by: Julien Veyssier <[email protected]> Signed-off-by: janepie <[email protected]>
janepie
force-pushed
the
fix/password-confirmation
branch
from
7610dd8 to
e989167
Compare
edward-ly
left a comment
edward-ly
left a comment
There was a problem hiding this comment.
Seems fine with me too, although some commit messages adhere to the Conventional Commits spec while others don't. Either now or in the future, choose whether you want to adhere to it or not and stick with it.
Signed-off-by: Jana Peper <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
No description provided.