-
Notifications
You must be signed in to change notification settings - Fork 725
Type annotations #6278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations #6278
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
d737101
to
59f9378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't spot any errors/typos. I've made some suggests to move the language to a active voice. Feel free to approve/reject as you see fit.
4c520f9
to
28157a6
Compare
Signed-off-by: Ben Sherman <[email protected]>
28157a6
to
9c87e64
Compare
Signed-off-by: Ben Sherman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some suggestions. I found the repetition of ", but..." made it harder to follow and made suggestions to change the flow.
Approved to prevent blocking.
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Ben Sherman <[email protected]>
This PR adds Nextflow-style type annotations for workflows, functions, and local variables.
Waiting for #5929 to be merged