Skip to content

Conversation

bentsherman
Copy link
Member

@bentsherman bentsherman commented Jul 15, 2025

This PR adds Nextflow-style type annotations for workflows, functions, and local variables.

Waiting for #5929 to be merged

@bentsherman bentsherman requested a review from pditommaso July 15, 2025 17:19
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit d16c643
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68ae24956a0a5c000758c440
😎 Deploy Preview https://deploy-preview-6278--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bentsherman bentsherman added this to the 25.10 milestone Jul 15, 2025
@bentsherman bentsherman force-pushed the type-annotations branch 4 times, most recently from d737101 to 59f9378 Compare July 18, 2025 22:55
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spot any errors/typos. I've made some suggests to move the language to a active voice. Feel free to approve/reject as you see fit.

@bentsherman bentsherman force-pushed the type-annotations branch 2 times, most recently from 4c520f9 to 28157a6 Compare August 8, 2025 16:00
Signed-off-by: Ben Sherman <[email protected]>
@bentsherman bentsherman marked this pull request as ready for review August 25, 2025 17:08
@bentsherman bentsherman requested review from a team as code owners August 25, 2025 17:08
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions. I found the repetition of ", but..." made it harder to follow and made suggestions to change the flow.

Approved to prevent blocking.

Co-authored-by: Chris Hakkaart <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
@bentsherman bentsherman merged commit 0008707 into master Aug 26, 2025
10 checks passed
@bentsherman bentsherman deleted the type-annotations branch August 26, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants