Refactor Tower client to use lib-httpx library #6357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace manual HTTP retry logic with HxClient from io.seqera:lib-httpx - Update TowerClient.sendHttpMessage() to use HxClient.sendAsString() - Add HxClient configuration with retry settings, JWT token, and refresh token handling - Update makeRequest() helper method to properly build HttpRequest objects with body content - Remove redundant HTTP response handling code in favor of HxClient built-in functionality - Update SimpleHttpClient to support content-type and authorization headers - Update tests to reflect API changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…-client-use-lib-httpx Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
- Add comprehensive annotations to TowerRetryPolicy with default values - Add Javadoc documentation to TowerRetryPolicy class explaining retry behavior - Fix missing annotations in WaveConfig BuildOpts class (conda, compression, maxDuration) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
pditommaso
merged commit 06ca439
into
refactor-wave-client-use-lib-httpx
17 of 18 checks passed
pditommaso
added a commit
that referenced
this pull request
Sep 3, 2025
* Refactor Wave client to use lib-httpx library - Replace manual HTTP retry logic with HxClient from io.seqera:lib-httpx:1.2.0 - Update RetryOpts to implement Retryable.Config interface from lib-retry - Add multiplier field to RetryOpts for exponential backoff configuration - Remove manual JWT token refresh logic in favor of HxClient built-in handling - Update WaveClient to use HxClient.sendAsString() instead of raw HttpClient - Remove redundant retry policy and HTTP response handling code - Update tests to reflect API changes and remove obsolete HTTP retry test 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Bump [email protected] Signed-off-by: Paolo Di Tommaso <[email protected]> * Improve integration Signed-off-by: Paolo Di Tommaso <[email protected]> * Refactor Tower client to use lib-httpx library (#6357) * Refactor Tower client to use lib-httpx library - Replace manual HTTP retry logic with HxClient from io.seqera:lib-httpx - Update TowerClient.sendHttpMessage() to use HxClient.sendAsString() - Add HxClient configuration with retry settings, JWT token, and refresh token handling - Update makeRequest() helper method to properly build HttpRequest objects with body content - Remove redundant HTTP response handling code in favor of HxClient built-in functionality - Update SimpleHttpClient to support content-type and authorization headers - Update tests to reflect API changes - Add comprehensive annotations to TowerRetryPolicy with default values - Add Javadoc documentation to TowerRetryPolicy class explaining retry behavior - Fix missing annotations in WaveConfig BuildOpts class (conda, compression, maxDuration) Signed-off-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Ben Sherman <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Ben Sherman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Extends the Wave client refactoring (#6354) to also update the Tower client
• Replace manual HTTP retry logic with HxClient from
io.seqera:lib-httpx• Update TowerClient.sendHttpMessage() to use HxClient.sendAsString() API
• Add proper HxClient configuration with retry settings, JWT token, and refresh token handling
• Simplify HTTP request creation and response handling by removing 18 lines of redundant code
Changes
io.seqera:lib-httpxdependencyTest plan
🤖 Generated with Claude Code