Skip to content

Bump Spock 2.4 #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pditommaso wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump Spock 2.4 #6681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f63520b
Bump Spock 2.4
pditommaso Dec 20, 2025
8bac1ce
Fix TaskRunTest for Spock 2.4 property stubbing
pditommaso Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/nextflow/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ dependencies {
testFixturesApi ("org.apache.groovy:groovy-test:4.0.29") { exclude group: 'org.apache.groovy' }
testFixturesApi ("org.objenesis:objenesis:3.4")
testFixturesApi ("net.bytebuddy:byte-buddy:1.14.17")
testFixturesApi ("org.spockframework:spock-core:2.3-groovy-4.0") { exclude group: 'org.apache.groovy' }
testFixturesApi ('org.spockframework:spock-junit4:2.3-groovy-4.0') { exclude group: 'org.apache.groovy' }
testFixturesApi ("org.spockframework:spock-core:2.4-groovy-4.0") { exclude group: 'org.apache.groovy' }
testFixturesApi ('org.spockframework:spock-junit4:2.4-groovy-4.0') { exclude group: 'org.apache.groovy' }
testFixturesApi 'com.google.jimfs:jimfs:1.2'
// note: declare as separate dependency to avoid a circular dependency
lineageImplementation (project(':nf-lineage'))
Expand Down
8 changes: 5 additions & 3 deletions modules/nextflow/src/test/groovy/nextflow/processor/TaskRunTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,11 +882,13 @@ class TaskRunTest extends Specification {
!task.isArray()
}

// note: use `stubRun >> value` instead of `getStubRun() >> value` because
// Spock 2.4 requires property stubbing for direct property access (session.stubRun)
def 'should resolve task body' () {
given:
def task = Spy(TaskRun)
task.processor = Mock(TaskProcessor) {
getSession()>>Mock(Session) { getStubRun() >> false}
getSession()>>Mock(Session) { stubRun >> false}
}
and:
def body = Mock(BodyDef)
Expand All @@ -902,7 +904,7 @@ class TaskRunTest extends Specification {
given:
def task = Spy(TaskRun)
task.processor = Mock(TaskProcessor) {
getSession()>>Mock(Session) { getStubRun() >> true}
getSession()>>Mock(Session) { stubRun >> true}
}
task.config = Mock(TaskConfig) { getStubBlock()>> null }
and:
Expand All @@ -923,7 +925,7 @@ class TaskRunTest extends Specification {
def task = Spy(TaskRun)
task.config = Mock(TaskConfig) { getStubBlock()>>stub }
task.processor = Mock(TaskProcessor) {
getSession()>>Mock(Session) { getStubRun() >> true}
getSession()>>Mock(Session) { stubRun >> true}
}

when:
Expand Down
Loading