fix(web): use semver comparison for update notification version check - #1770
Merged
Conversation
String comparison fails for multi-digit version components (e.g. "3.10.0" < "3.9.0" lexicographically). Use semver.gt() which is already used elsewhere in the web app (fetchDatasetsIndex.ts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: fix(web): use semver comparison for update notification version check
fix/web-version-comparison->masterSummary
UpdateNotification.tsxcompared app versions with JavaScript string>, which fails for multi-digit semver components ("3.10.0" < "3.9.0"lexicographically). Replaced withsemver.gt()-- thesemverpackage is already a dependency and used correctly infetchDatasetsIndex.ts.Changes
semverinUpdateNotification.tsxappJson.version > (lastNotifiedAppVersion ?? PACKAGE_VERSION ?? '')withsemver.gt(appJson.version, lastNotifiedAppVersion ?? PACKAGE_VERSION ?? '0.0.0')''to'0.0.0'(valid semver required bysemver.gt())Related
Follow-up to: #1769 (same defect class, Rust side)