-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.12.0 #794
base: master
Are you sure you want to change the base?
Release 2.12.0 #794
Conversation
Bump version 2.12.0dev
…4straub/ampliseq into merging-template-updates_3.0.2
merging template updates v3.0.2
fix --dada_ref_taxonomy silva=132
Remove white space in process tags
Update Picrust2 and nf-core modules
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
modules/local/picrust.nf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ambition on adding the local modules to nf-core/modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik this module only helpful for 16S amplicon sequencing, so nothing of broader interest. True for most if not all local modules. So not worth the trouble I think.
Release 2.12.0
Before being ready for review:
Fails unexpected indonenf-core linting / nf-core (pull_request)
withincluded_configs: Pipeline config does not include custom configs. Please uncomment the includeConfig line.
AWS full size test manual triggerdonemanually triggered AWS full size test succeededdoneVersion update from 2.12.0dev to 2.12.0donePotentially address phred score mis-detection by dada2 #773 by adding a new parameterpostponedWhen achieved 2 reviewer approvals, before merging, check if AWS full size test automatically triggered!
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).