Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.12.0 #794

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Release 2.12.0 #794

wants to merge 33 commits into from

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Nov 13, 2024

Release 2.12.0

Before being ready for review:

  • Fails unexpected in nf-core linting / nf-core (pull_request) with included_configs: Pipeline config does not include custom configs. Please uncomment the includeConfig line. done
  • AWS full size test manual trigger done
  • manually triggered AWS full size test succeeded done
  • Version update from 2.12.0dev to 2.12.0 done
  • Potentially address phred score mis-detection by dada2 #773 by adding a new parameter postponed

When achieved 2 reviewer approvals, before merging, check if AWS full size test automatically triggered!

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Nov 13, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ca63a52

+| ✅ 298 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-14 13:15:57

@d4straub d4straub mentioned this pull request Nov 13, 2024
11 tasks
@d4straub d4straub changed the title Release 2.12.0 - TEST Release 2.12.0 Nov 14, 2024
@d4straub d4straub marked this pull request as ready for review November 14, 2024 10:49
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any ambition on adding the local modules to nf-core/modules?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik this module only helpful for 16S amplicon sequencing, so nothing of broader interest. True for most if not all local modules. So not worth the trouble I think.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants