Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sanger.config #512

Merged
merged 6 commits into from
Jul 3, 2023
Merged

Update sanger.config #512

merged 6 commits into from
Jul 3, 2023

Conversation

DLBPointon
Copy link
Contributor

Added small and week queues


name: New Config
about: A new cluster config

Closes #511

Please follow these steps before submitting your PR:

  • Your PR targets the master branch
  • You've included links to relevant issues, if any

I'm submitting an update to the sanger config to add values for the small and week queues.

Added small and week queues
@DLBPointon DLBPointon added the enhancement New feature or request label Jun 20, 2023
@DLBPointon DLBPointon self-assigned this Jun 20, 2023
@DLBPointon DLBPointon added the WIP Work in progress label Jun 20, 2023
@priyanka-surana
Copy link
Contributor

priyanka-surana commented Jun 20, 2023

Can you integrate an upper time limit as well? If a job requests more than 30 days, exit with error.
Also add an upper memory limit for a single job to 196GB based on Farm advice: https://ssg-confluence.internal.sanger.ac.uk/display/FARM/What+are+the+memory+limits+on+the+farm -- The document is entirely correct.

@DLBPointon
Copy link
Contributor Author

Can you integrate an upper time limit as well? If a job requests more than 30 days, exit with error.

Done.

Added end case for testing
@DLBPointon
Copy link
Contributor Author

DLBPointon commented Jun 21, 2023

@priyanka-surana Had to add an else statement which kind of negates the max mem, is there a exit statement that can be used here?

@priyanka-surana priyanka-surana merged commit f494b00 into nf-core:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanger.config update for small and week
3 participants