Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to explicitly request review #520

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Update docs to explicitly request review #520

merged 3 commits into from
Jul 3, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jul 3, 2023

name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

@jfy133 jfy133 requested a review from a team July 3, 2023 08:32
JoseEspinosa
JoseEspinosa approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jfy133 jfy133 merged commit 1bdead2 into master Jul 3, 2023
@jfy133 jfy133 deleted the docs branch July 3, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@jasmezz jasmezz jasmezz approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@matthdsm matthdsm matthdsm approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jfy133 @maxulysse @JoseEspinosa @mirpedrol @matthdsm @FriederikeHanssen @jasmezz @nvnieuwk