Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hasta.config #558

Closed
wants to merge 1 commit into from
Closed

Conversation

LilyAnderssonLee
Copy link
Contributor

@LilyAnderssonLee LilyAnderssonLee commented Sep 26, 2023


name: hasta.config

In order to run taxprofiler on hasta, genomes,fasta was added to hasta.config to support newer nf-validation for ignored params

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any
  • Requested review from @nf-core/maintainers and/or #request-review on slack

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

@LilyAnderssonLee LilyAnderssonLee changed the title add genomes,fasta to hasta.config to support newer nf-validation for ignored params update hasta.config Sep 26, 2023
@mashehu
Copy link
Contributor

mashehu commented Sep 26, 2023

will this not create problems for other pipelines and should therefore a pipeline specific config not be the preferred route?

@jfy133 jfy133 self-requested a review September 26, 2023 13:14
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mashehu is correcT! You need to make or update the pipeline specific ocnfog!

@LilyAnderssonLee
Copy link
Contributor Author

LilyAnderssonLee commented Sep 26, 2023

Yes you are right. I will close this PR and will just update this one https://github.com/nf-core/configs/blob/master/conf/pipeline/taxprofiler/hasta.config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants