-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev -> master for v1.1.0 #95
Conversation
Bumping to 1.1.0dev
Empty ref to samtools sort
feat(metro-map): update metro map for better cohesion with rnaseq
Important! Template update for nf-core/tools v2.14.1
Bump versions pre-release to 1.1.0
|
Fix minor linting issue for release
Remove the on_pull_request_target trigger from the download test.
Bump gunzip due to release CI failure
Remove conda from release CI
Fix gunzip in snapshot
@@ -26,11 +26,11 @@ | |||
|
|||
- [FastQC](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/) | |||
|
|||
> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online]. | |||
> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online]. | |
> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online]. |
|
||
- [MultiQC](https://pubmed.ncbi.nlm.nih.gov/27312411/) | ||
|
||
> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924. | ||
> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924. | |
> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924. |
@@ -27,6 +27,57 @@ CONTROL_REP1,AEG588A1_S1_L003_R1_001.fastq.gz,AEG588A1_S1_L003_R2_001.fastq.gz,a | |||
CONTROL_REP1,AEG588A1_S1_L004_R1_001.fastq.gz,AEG588A1_S1_L004_R2_001.fastq.gz,auto,riboseq | |||
``` | |||
|
|||
### Linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Linting | |
### FastQ Linting |
I'd say linting is not specific enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have minor comments
Thanks @maxulysse ! If you don't mind, I'll resist addressing those for this release and triggering anther round of CI, I'll sort them in the post-release version bump PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of changed files indeed. I have run the workflow quite a few times lately, and it all seems to have worked well, including the UMI splitting. Very happy with the new release.
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).