Apply charge limit over BLE - #656
Closed
MikeBishop wants to merge 5 commits into
Closed
Conversation
Only skip applyChargeLimit retry if the same limit is being applied again. This allows changing from one limit to another (e.g., 80% → 90%) and fixes the issue where restore (limit=-1) would retry indefinitely.
Test Results 8 files ±0 8 suites ±0 13m 16s ⏱️ -1s For more details on these failures, see this check. Results for commit 86e8be9. ± Comparison against base commit 6c41416. ♻️ This comment has been updated with latest results. |
Track attempted_count and skipped_count separately in applyChargeLimit instead of conflating them into success_count. Only log info message if attempted_count > 0, avoiding misleading logs when all vehicles are skipped (already applied or no saved limit). Log format now shows: "X/Y attempted succeeded, Z skipped" when commands are attempted, or silently succeeds when all vehicles are already handled (skipped). Mirrors the fix applied to car_api_charge().
Collaborator
Author
|
I think this accidentally replaced the stop asking variable rather than mirroring it. Please don't merge until I have time to look more closely (or you do). |
Owner
|
Superseded by #657, which includes the charge limit changes (plus keeps the _stopAskingToStartCharging init that this branch dropped) and the BLE state fetching. Merged that instead. |
Collaborator
Author
|
Sorry, I tried to untangle them and apparently failed. 😔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.