fix: actually start the TeslaMate token resync timer - #664
Open
MikeBishop wants to merge 1 commit into
Open
Conversation
The hourly resync Timer was constructed but never started (and not stored), so token-sync mode only ever synced once at startup despite the comment claiming an hourly refresh. Start it, and have it reschedule itself so resyncs keep happening indefinitely.
Test Results4 456 tests ±0 4 352 ✅ ±0 13m 28s ⏱️ -3s For more details on these failures, see this check. Results for commit 91f266f. ± Comparison against base commit 827e71d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hourly resync Timer was constructed but never started (and not stored), so token-sync mode only ever synced once at startup despite the comment claiming an hourly refresh. Start it, and have it reschedule itself so resyncs keep happening indefinitely.
(Noticed incidentally while fixing something else; I don't use this path myself, and it might not be relevant with the switch to Fleet API while TeslaMate hasn't yet.)