chore: use gettext-envsubst alpine package instead of workaround #976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As of Alpine v3.18 the
envsubst
command has been split out into it's own package (gettext-envsubst
), so the workaround to extract it from thegettext
package is no longer required.https://pkgs.alpinelinux.org/packages?name=gettext-envsubst&branch=v3.18
Note
I just intended to create this PR as a quick edit while I was working on something else instead of creating a ticket. I see that there's more steps required for PRs and I can come back at some point and complete the rest of the steps, or someone else is welcome to reuse/complete this!
Checklist
Before creating a PR, run through this checklist and mark each as complete:
./update.sh
and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & DockerfilesREADME.md
and/ormodules/README.md
)