Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use gettext-envsubst alpine package instead of workaround #976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

computator
Copy link

@computator computator commented Apr 6, 2025

Proposed changes

As of Alpine v3.18 the envsubst command has been split out into it's own package (gettext-envsubst), so the workaround to extract it from the gettext package is no longer required.

https://pkgs.alpinelinux.org/packages?name=gettext-envsubst&branch=v3.18

Note

I just intended to create this PR as a quick edit while I was working on something else instead of creating a ticket. I see that there's more steps required for PRs and I can come back at some point and complete the rest of the steps, or someone else is welcome to reuse/complete this!

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and/or modules/README.md)

@computator computator requested a review from a team as a code owner April 6, 2025 03:36
Copy link

github-actions bot commented Apr 6, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@computator
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant