Skip to content

Update aws nlb manifests installation #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bjee19
Copy link

@bjee19 bjee19 commented May 8, 2025

There is no longer an aws-nlb deploy.yaml file, so we need to update the manifests installation and give some information on setting annotations in the Gateway.

Problem: There is no longer an aws-nlb deploy.yaml file, so we need to update documentation.

Solution: Update the documentation and give information on setting annotations on the Gateway.

Testing: Checked with make watch

Related with: nginx/nginx-gateway-fabric#3362

Closes

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@bjee19 bjee19 requested a review from a team as a code owner May 8, 2025 22:26
@bjee19 bjee19 requested a review from a team May 8, 2025 22:26
@github-actions github-actions bot added documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric labels May 8, 2025
@ADubhlaoich ADubhlaoich merged commit 45b70e1 into nginx:ngf-feature-cp-dp-split May 13, 2025
6 checks passed
kubectl apply -f https://raw.githubusercontent.com/nginx/nginx-gateway-fabric/v{{< version-ngf >}}/deploy/default/deploy.yaml
```

To set up an AWS Network Load Balancer service, add these annotations to your Gateway infrastructure fields:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see this PR until it's too late.

I'd update this to show the Gateway spec and the infrastructure labels field so it's very clear where to set these labels. "infrastructure fields" may not be understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants