Implement ProxySettingsPolicy #4286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
reviewed
Nov 14, 2025
|
|
||
| // parseNginxSize parses an NGINX size string (e.g., "8k", "16m", "1024") and returns the size in bytes. | ||
| // Returns an error if the size string is invalid. | ||
| func parseNginxSize(size string) (int64, error) { |
Collaborator
There was a problem hiding this comment.
Can we have a dedicated unit test for this function?
| // HTTP2 should be enabled by default | ||
| HTTP2: true, | ||
| IPFamily: Dual, | ||
| Policies: buildPolicies(gateway, gateway.Policies), |
Collaborator
There was a problem hiding this comment.
Is this going to build client settings policies objects too and attach to this struct?
shaun-nx
reviewed
Nov 17, 2025
Comment on lines
134
to
+135
| // PolicyAffectedReason is used with the "PolicyAffected" condition when a | ||
| // ObservabilityPolicy or ClientSettingsPolicy is applied to Gateways or Routes. | ||
| // ObservabilityPolicy, ClientSettingsPolicy, or ProxySettingsPolicy is applied to Gateways or Routes. |
Contributor
There was a problem hiding this comment.
Does PolicyAffectedReason only apply to these three policies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We need to implement the ProxySettingsPolicy API
Solution: Implement ProxySettingsPolicy
Manual Testing: Tested using the example files provided which will be the basis of the documentation:
Steps (using the provided examples):
Also tested the validation works as expected.
Note that the
Programmedstatus implementation, CEL, and functional testing will all be done in follow up PRsCloses #4261
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.