Skip to content

Issue 32 lint unsafe #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Issue 32 lint unsafe #44

merged 2 commits into from
Aug 28, 2023

Conversation

ivanitskiy
Copy link
Contributor

@ivanitskiy ivanitskiy commented Aug 28, 2023

Proposed changes

this PR complements changes from #38.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Matthew Yacobucci and others added 2 commits August 28, 2023 12:00
Dereferencing raw pointers is inherently unsafe. To satisfy clippy these
functions and their callers require an unsafe indicator.
@ivanitskiy ivanitskiy merged commit ad093d8 into master Aug 28, 2023
@ivanitskiy ivanitskiy deleted the issue-32-lint-unsafe branch August 28, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant