QuickJS: crypto module. #863
Merged
+1,250
−434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimZhestikov
force-pushed
the
qjs_crypto_module
branch
5 times, most recently
from
1eb9e5c to
0cf8b87
Compare
xeioex
previously requested changes
Mar 18, 2025
|
See changes I made here: https://github.com/xeioex/njs/commits/qjs_crypto_module/ Cherry-pick Test262: allowing to omit empty default option argument. Test262: using default prepare_args() where appropriate. Individually. Everything else can be squashed to the original commit. |
VadimZhestikov
force-pushed
the
qjs_crypto_module
branch
from
0cf8b87 to
03879f0
Compare
VadimZhestikov
dismissed
xeioex’s stale review
Applied proposed changes from xeioex.
xeioex
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.