Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickJS: making argument styles consistent in ngx_js.h. #865

Merged
merged 1 commit into from
Mar 18, 2025
Merged

QuickJS: making argument styles consistent in ngx_js.h. #865

merged 1 commit into from
Mar 18, 2025

Conversation

hongzhidao
Copy link
Contributor

Prepared for QuickJS fetch support.

@hongzhidao hongzhidao requested a review from xeioex March 17, 2025 08:22
xeioex
xeioex requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small improvement for the commit log:

QuickJS: making argument styles consistent in ngx_js.h. -> QuickJS: making ngx_qjs_*() functions consistent with ngx_js_*().

Otherwise looks good.

@xeioex xeioex self-requested a review March 18, 2025 01:02
@hongzhidao hongzhidao merged commit 9010aee into nginx:master Mar 18, 2025
1 check passed
@hongzhidao hongzhidao deleted the qjs-refactor branch March 18, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeioex xeioex xeioex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongzhidao @xeioex