Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickJS: fixed ngx_qjs_string(). #867

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

hongzhidao
Copy link
Contributor

Fix the function to properly handler strings like "\0" which happens in tests. In js_fetch_objects.t:

for (var i = 0; i < 128; i++) {
  var c = String.fromCodePoint(i);

Refactored out from qjs fetch patches.

@xeioex xeioex self-requested a review March 18, 2025 22:45
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit log:

QuickJS: fixed ngx_qjs_string() to handle strings containing "\0".

Otherwise Looks good.

xeioex
xeioex previously approved these changes Mar 19, 2025
@hongzhidao hongzhidao force-pushed the qjs-fix-2 branch 2 times, most recently from 2dcf108 to 3637955 Compare March 19, 2025 05:44
@hongzhidao hongzhidao merged commit 1b7adef into nginx:master Mar 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants