Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickJS: using JS_AddIntrinsicBigInt() if detected. #870

Merged
merged 1 commit into from
Mar 20, 2025
Merged

QuickJS: using JS_AddIntrinsicBigInt() if detected. #870

merged 1 commit into from
Mar 20, 2025

Conversation

VadimZhestikov
Copy link
Contributor

@VadimZhestikov VadimZhestikov commented Mar 19, 2025 •
edited
Loading

In quickjs JS_AddIntrinsicBigInt() is moved from public API to JS_AddIntrinsicBaseObjects():

commit 6d6893bfa3d383d4952b67954003800aba1f4be8
Author: Fabrice Bellard [email protected]
Date: Wed Mar 19 12:33:54 2025 +0100

fixed BigInt hashing - removed -fno-bigint in qjsc and JS_AddIntrinsicBigInt() (BigInt is now considered as a base object)

@VadimZhestikov VadimZhestikov requested a review from xeioex March 19, 2025 16:42
@VadimZhestikov VadimZhestikov marked this pull request as ready for review March 19, 2025 16:42
xeioex

This comment was marked as duplicate.

Sign in to view

xeioex
xeioex previously requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current approach seems unreliable and depends on the exact version of the libquickjs.a or NG version.
Let's do the configure check for JS_AddIntrinsicBigInt() here.

@VadimZhestikov VadimZhestikov force-pushed the JS_AddIntrinsicBigInt branch from c9bce30 to 0586245 Compare March 20, 2025 00:38
@VadimZhestikov VadimZhestikov changed the title QuickJS: use JS_AddIntrinsicBigInt() for quickjs-ng only. QuickJS: use JS_AddIntrinsicBigInt() if it is detected. Mar 20, 2025
@VadimZhestikov VadimZhestikov dismissed xeioex’s stale review March 20, 2025 00:43

Autodetection is used now.

@VadimZhestikov VadimZhestikov force-pushed the JS_AddIntrinsicBigInt branch from 20c2dc6 to b04d84e Compare March 20, 2025 00:47
@VadimZhestikov VadimZhestikov requested a review from xeioex March 20, 2025 01:09
xeioex
xeioex previously requested changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit log:

QuickJS: using JS_AddIntrinsicBigInt() if detected.

Otherwise looks good.

@VadimZhestikov VadimZhestikov force-pushed the JS_AddIntrinsicBigInt branch from b04d84e to 3421a5f Compare March 20, 2025 02:35
@VadimZhestikov VadimZhestikov changed the title QuickJS: use JS_AddIntrinsicBigInt() if it is detected. QuickJS: using JS_AddIntrinsicBigInt() if detected. Mar 20, 2025
@VadimZhestikov VadimZhestikov dismissed xeioex’s stale review March 20, 2025 02:37

Commit log is updated

@VadimZhestikov VadimZhestikov requested a review from xeioex March 20, 2025 02:37
@VadimZhestikov VadimZhestikov merged commit f3454f0 into nginx:master Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeioex xeioex xeioex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VadimZhestikov @xeioex