generated from nginxinc/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Well-begun... #13
Draft
ciroque
wants to merge
38
commits into
main
Choose a base branch
from
steve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Well-begun... #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdutta9
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a media
sub directory, within lab8 and move all the images to that sub directory to keep it consistent with the other labs.
* lab3 updates
* minor updates in lab1 and lab6 * lab7 wip
* Initial push of notes * adding ingress-demo container files * updating instructions * updating instructions * updating instructions * Pushing notes up for review * Fixing typos and a few errant statements. * Cleaning up image and readme document. * More typo's fixed. * Moving Lab10 into the main folder with changes suggested in a.m. review. * Cleaning up stuff that shouldn't be in the repo.
* lab1 and lab2 updates
* add lab1 diagrams * lab2 screenshots added
* lab2 minor config update * lab1 minor update * lab3 updates WIP * lab3 updates * minor update * refactory * refactory * lab3 wip * lab3 wip * lab3 wip * lab3 wip * lab3 wip * lab3 wip * lab3 final * refactory
* lab4 edits * lab3 icon updates
* lab5 diagram/icons * lab5 graphics * add redis and headless --------- Co-authored-by: Shouvik <[email protected]>
* lab6 icons * lab6 updates
* lab5 diagram/icons * add redis and headless * fix keepalive * lab3 fixes
* Initial push of notes * adding ingress-demo container files * updating instructions * updating instructions * updating instructions * Pushing notes up for review * Fixing typos and a few errant statements. * Cleaning up image and readme document. * More typo's fixed. * Moving Lab10 into the main folder with changes suggested in a.m. review. * Cleaning up stuff that shouldn't be in the repo. * Updated the json file to include more Visualizations and added the images to match the new layout. * Updated Dashboard
* lab5 diagram/icons * lab5 graphics * lab5 graphics * add redis and headless * add redis and headless * fix keepalive * lab3 fixes * repo files updated * new readme * lab0 initial * lab0 initial * removed ca-notes * lab9 screenshots * lab9 screenshots
Fixed last code blocks which weren't formatiing.
added changes from s.dutta
* updating .gitignore * logs done * added monitoring example
* deleted sd-notes directory * updated readme
* lab5 diagram/icons * lab5 graphics * lab5 graphics * add redis and headless * add redis and headless * fix keepalive * lab3 fixes * repo files updated * new readme * lab0 initial * lab0 initial * removed ca-notes * lab9 screenshots * lab9 screenshots * lab9 updates * lab9 updates * lab9 updates * lab9 updates * remove outline
* swapped labs * refactory
* refactory in lab5 * lab6 updates * lab1 updates * lab1 updates * updated command for fetching self public IP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the steps for Lab 8.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)