generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 4
Added new UI smoke tests #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd7a504
to
55ede8e
Compare
✅ Deploy Preview will be available once build job completes!
|
This comment was marked as outdated.
This comment was marked as outdated.
5e465a9
to
a40c00f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
a40c00f
to
da887f4
Compare
4c09ce5
to
a33bd6b
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
1a4f7b0
to
22bffc7
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
22bffc7
to
def53e0
Compare
nginx-jack
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for me locally.
I did need to do an npm i
.
Whatever way playwright works, it still requires the dependencies installed, if when using npx. I'm fine with it, for tests though!
3653196
to
a5c8b2a
Compare
maximusmith529
pushed a commit
that referenced
this pull request
Sep 10, 2025
* Tests: Added new UI smoke tests * Tests: Fix issue where consent pops up after click event * Tests: Fix tests + biome * Tests: Add test for tabs * Tests: Add webkit + add comment for geolocation * Tests: Fix header test on webkit * Tests: Make test less flaky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding initial smoke test to footer, content, header, and sidebar.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)