Updates README for documenting the saml_idp_response_url variable #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documentation points aims to help users solving non working IdP initiated Single Logout due to a potential endpoints difference between the SingleLogoutRequest and SingleLogoutResponse consumption endpoints on the IdP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation update aims to help users solving non working IdP initiated Single Logout due to a potential endpoints difference between the SingleLogoutRequest and SingleLogoutResponse consumption endpoints on the IdP.
Indeed, the
saml_idp_response_urlvariable is used for this purpose in saml_sp.js#L1230 but is never populated by saml_sp_configuration.conf.I personally first added some code to the NJS script before realizing this step is already done for us, there only needs to be a variable setting.
F5 Big IP APM notably has 2 different endpoints for SingleLogoutRequest and SingleLogoutResponse. This change will ease the integration of NGINX with F5 Big IP APM IdP for example.