Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tree-shake injection token names #172

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

arturovt
Copy link
Collaborator

@arturovt arturovt commented Jan 1, 2025

No description provided.

Copy link

stackblitz bot commented Jan 1, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@arturovt arturovt force-pushed the refactor/tree-shake branch from 819afbd to ff51f57 Compare January 1, 2025 14:11
@arturovt
Copy link
Collaborator Author

arturovt commented Jan 1, 2025

@NetanelBasal could you give me access rights to merge?

@NetanelBasal
Copy link
Member

done

@arturovt
Copy link
Collaborator Author

arturovt commented Jan 1, 2025

I think still not able to merge... (only close issues)

@NetanelBasal
Copy link
Member

Write role can't merge?

@NetanelBasal
Copy link
Member

You should be able to merge with write role

@arturovt
Copy link
Collaborator Author

arturovt commented Jan 1, 2025

image

@NetanelBasal
Copy link
Member

Maybe because it's an existing PR or something. I will merge and let's see in next PR

@NetanelBasal NetanelBasal merged commit 5a61e98 into ngneat:master Jan 1, 2025
2 checks passed
@arturovt arturovt deleted the refactor/tree-shake branch January 1, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants