Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› type check on component outputs #693

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

lneumeier
Copy link
Contributor

@lneumeier lneumeier commented Feb 6, 2025

Allow subjects as component output

βœ… Closes: #689

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #689

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

stackblitz bot commented Feb 6, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Allow subjects as component output

βœ… Closes: ngneat#689
@lneumeier lneumeier force-pushed the bugfix-689-output-subject branch from 744613c to 10a8bef Compare February 6, 2025 22:40
@NetanelBasal NetanelBasal merged commit 08c9a21 into ngneat:master Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Output with ReplaySubject no longer working
2 participants