Skip to content

Equals is ignored for Components that contain collection #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Equals is ignored for Components that contain collection #3541

wants to merge 7 commits into from

Conversation

DmitryMak
Copy link

Test that explains the intent in #3539

hazzik
hazzik reviewed May 3, 2024
View reviewed changes
hazzik
hazzik reviewed May 3, 2024
View reviewed changes
@hazzik
Copy link
Member

hazzik commented May 3, 2024

Ok. I've fixed tests... But they still fail. Seems legit bug.

@DmitryMak
Copy link
Author

Ok. I've fixed tests... But they still fail. Seems legit bug.

Thank you! FWIW I tried to use collection-type and a custom IUserCollection with Wrap overridden to wrap the new HashSet into a PersistentGenericSet, but the result was the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hazzik hazzik hazzik left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DmitryMak @hazzik