Update dependencies and bump version on each package#109
Closed
ninogjoni wants to merge 7 commits intonhost:mainfrom
Closed
Update dependencies and bump version on each package#109ninogjoni wants to merge 7 commits intonhost:mainfrom
ninogjoni wants to merge 7 commits intonhost:mainfrom
Conversation
- nhost_auth_dart@1.0.1 - nhost_dart@1.0.1 - nhost_flutter_auth@3.0.1 - nhost_flutter_graphql@3.0.1 - nhost_functions_dart@1.0.1 - nhost_gql_links@3.0.1 - nhost_graphql_adapter@3.0.1 - nhost_sdk@4.0.1 - nhost_storage_dart@1.0.1
Contributor
|
@ninogjoni Thank you for the PR, it looks pretty ok, but there are lots of formatting changes that are not really necessary for this PR, can you ensure that those are fixed? also please take care of the failed CI checks. |
Author
|
@mhadaily I corrected things and did an analysis locally beforehand with |
Contributor
|
Awesom, thank you, I will merge this and publish a new version soon |
Contributor
|
Hi, can we update it to http 1.1.0 instead? |
Author
|
Contributor
|
Hey @ninogjoni I am sorry again but I tried to start reviewing and merge this PR but it looks like now we have lots of conflicts on your branch. can you take a look? |
Author
Contributor
|
Hi
Can you just check the unchanged file from git? Let’s not have formatting
in the PR
And you should upgrade your package again and consider latest versions that
I just published and bump based on that
On Tue, 29 Aug 2023 at 20:24, Nino Gjoni ***@***.***> wrote:
Hi @mhadaily <https://github.com/mhadaily>
There were still my auto formatting changes in the workflows... Also,
three packages have already been updated to x.x.1 (see #102
<#102>) didn't know now if my
changes could also go in there. Or will there be conflicts with pub.dev?
—
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKDTCYWHJJAWUDGUHB2YHLXXYXUXANCNFSM6AAAAAA3FQBOGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Best regards, *
Majid
|
Author
|
Hey,
I was sure that I had already undone the formatting (apparently I did
not...) My mistake, sorry! Hopefully I've reversed the workflow files
properly and updated the versions now, made a PR.
Best regards,
Nino
… Hi
Can you just check the unchanged file from git? Let’s not have
formatting
in the PR
And you should upgrade your package again and consider latest
versions that
I just published and bump based on that
On Tue, 29 Aug 2023 at 20:24, Nino Gjoni ***@***.***> wrote:
> Hi @mhadaily <https://github.com/mhadaily>
>
> There were still my auto formatting changes in the workflows...
Also,
> three packages have already been updated to x.x.1 (see #102
> <#102>) didn't know now if
my
> changes could also go in there. Or will there be conflicts with
pub.dev?
>
> —
> Reply to this email directly, view it on GitHub
>
<#109 (comment)>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAKDTCYWHJJAWUDGUHB2YHLXXYXUXANCNFSM6AAAAAA3FQBOGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
*Best regards, *
Majid
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you were mentioned.Message ID:
***@***.***>
Links:
------
[1]
#109 (comment)
[2]
https://github.com/notifications/unsubscribe-auth/ALYJA6VEOJWGXNLLJLY5JQDXXY2PXANCNFSM6AAAAAA3FQBOGY
|
Member
|
Closing as this is old and very much outdated by now. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.